Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up the backwards pass of type 1 #74

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Tidy up the backwards pass of type 1 #74

merged 4 commits into from
Oct 10, 2023

Conversation

WardBrian
Copy link
Collaborator

  1. Clean up something where we were doing an fftshift, multiply, and ifftshift to just do 1 fftshift of the thing we were multiplying by
  2. Remove the need to call FINUFFT multiple times in the points derivative by using the built-in batching functionality
  3. Remove the numpy logic creating the ramp and replace it with a torch-native solution

@WardBrian WardBrian requested a review from eickenberg October 10, 2023 18:40
eickenberg
eickenberg approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@eickenberg eickenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very cool. some minor questions

pytorch_finufft/functional.py Outdated Show resolved Hide resolved
pytorch_finufft/functional.py Show resolved Hide resolved
pytorch_finufft/functional.py Show resolved Hide resolved
@WardBrian WardBrian mentioned this pull request Oct 10, 2023
Merged
@WardBrian WardBrian merged commit d58e815 into main Oct 10, 2023
0 of 4 checks passed
@WardBrian WardBrian deleted the cleanup/t1-backward branch October 10, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eickenberg eickenberg eickenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WardBrian @eickenberg